wire Fireworks distillation smoke test path - #5
Draft
yi-fireworks wants to merge 8 commits into
Draft
Conversation
http_timeout=120.0
cursor add retry
hack sampler_path
checkpoint_type="base"
comment out kl_sample_train_metrics
max_concurrency = 8
default 4
cursor added max_concurrency
print
sampling_client = DeploymentSampler( for async
0
['choices']
contents
logprobs=True,
print("sample_result:", sample_result)
remove max_seq_len
max_tokens=19200
field
add back dataclass
FireworksTokenCompleter in metric_util
fix tokenizer
http://localhost:8902
remove dataclass for FireworksTokenCompleter
state_name, sampler_name
FireworksTokenCompleter
eval_semaphore
replace firetitan in rl path
squash
dash
comment compute_mean_nll
print fwd_bwd_result
print(f"fwd_bwd_result.loss_fn_outputs
print(f"len(logprobs) = {len(logprobs)}")
base_url: str = "http://localhost:8099"
import FiretitanTrainingClient
no await on service_client.create_training_client
lora_rank=config.lora_rank
fix FiretitanTrainingClient import
Replace for SFT
Revert "train_unembed=False"
This reverts commit 89c976d.
Revert "rank"
This reverts commit e14eeb4.
Revert "use tinker client temporarily"
This reverts commit 0106c20.
Revert "create_lora_training_client"
This reverts commit e905aa6.
rank
create_lora_training_client
use tinker client temporarily
train_unembed=False
Revert "attach grads as well"
This reverts commit 5ab4387.
attach grads as well
remove last_call_logprobs
base_url = None
write weights as well.
Claude hack
Add custom loss
add log
resume_info
open-research
train_on_what = TrainOnWhat.LAST_ASSISTANT_MESSAGE
unmatch )
Support Qwen3-30B-A3B-Thinking-2507
revert some changes.
delta checkpoint
max_concurrency: int = 2
max_concurrency: int = 4 for 1 GPU
use FireworksTokenCompleter in rollouts.py
path_dict
fireworks_base_model_name
save initially
Revert "try cursor fix (i don't think it's correct)"
This reverts commit b772b9f.
try cursor fix (i don't think it's correct)
sync
Add fireworks_deployment_id
remove api_key in deploymentsampler
fireworks_hot_load_timeout
ordering weight_syncer
add weight_syncer
now setup runs
print with hydra style
remove reference of self.
copy over
ppo
sample_result, _
async_completions_stream
use built-in grpo
use ppo_loss_fn instead
ALL_ASSISTANT_MESSAGES for open researcher
policy_ep
Add custom RL loss
works
use lora
fireworks_deployment_id in CLIConfig
cfg
revert
Refactor on-policy distillation to build Fireworks-specific runtime state and adapt the recipe to the public training SDK so a CPU-only orchestrator can drive remote rollout and training far enough to isolate the remaining forward_backward stall. Made-with: Cursor
1stprinciple
force-pushed
the
firetitan-server
branch
2 times, most recently
from
April 7, 2026 02:12
48fa4ec to
debad83
Compare
1stprinciple
force-pushed
the
firetitan-server
branch
from
April 18, 2026 00:04
cd90795 to
a4b44fb
Compare
1stprinciple
force-pushed
the
firetitan-server
branch
from
April 29, 2026 15:10
1accc2e to
00ea555
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WeightSyncerAPIforward_backward_async(...)callCurrent blocker / help wanted
The smoke test now gets through rollout sampling, minibatch assembly, teacher KL, and deployment hotload, but the actual training RPC still hangs.
What we observed:
await training_client.forward_backward_async(...)What we ruled out:
loss_fn=cross_entropyandkl_penalty_coef=0While the run is stuck, the trainer job still reports:
JOB_STATE_RUNNINGOKIf anyone familiar with this trainer path can help, the main question is whether this endpoint / SDK path is expected to support
forward_backward_asyncin this configuration, or whether there is a known issue with this shape / model /lora_rank=0setup.Repro command
Full distillation-path repro:
Control repro that still hangs even without distillation loss / KL:
Test plan
py_compileon touched filesforward_backward_asyncthrough the remote trainerMade with Cursor