Stop using --wait with helm deployments
#5810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on 2i2c-org#5809, I finally got frustrated enough with our usage of `--wait` that I've ripped it out. The major issue with `--wait` is that if the deployment fails (because of a typo in config for example), you *must* wait for the 5min timeout or helm can get into an inconsistent state. This sucks when prototyping. I stole the code we use in the mybinder.org deployment repo instead (https://github.com/jupyterhub/mybinder.org-deploy/blob/main/deploy.py#L273). It also seems faster, but the most important capability here is that it's cancellable.
for more information, see https://pre-commit.ci
|
Merging this PR will trigger the following deployment actions. Support deploymentsNo support upgrades will be triggered Staging deployments
Production deployments
|
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/14118691096 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #5809, I finally got frustrated enough with our usage of
--waitthat I've ripped it out.The major issue with
--waitis that if the deployment fails (because of a typo in config for example), you must wait for the 5min timeout or helm can get into an inconsistent state. This sucks when prototyping.I stole the code we use in the mybinder.org deployment repo instead (https://github.com/jupyterhub/mybinder.org-deploy/blob/main/deploy.py#L273).
It also seems faster, but the most important capability here is that it's cancellable.