Style/#374 공통여정 퀘스트 신고&차단 바텀시트 및 토스트메시지 추가#378
Merged
Conversation
1 task
dev-domo
approved these changes
Feb 24, 2026
Collaborator
dev-domo
left a comment
There was a problem hiding this comment.
바텀시트를 만들어주심에 감사를 표합니다...
| $0.spacing = 12.adjustedW | ||
| } | ||
| stackView.addArrangedSubviews(icon, label) | ||
| // stackView.snp.makeConstraints { |
Collaborator
There was a problem hiding this comment.
필요없는 주석이라면 삭제해도 될 것 같습니다!
| sheetType.items.enumerated().forEach { index, item in | ||
| let rowView = makeItemRow(item: item) | ||
| itemList.append(rowView) | ||
| contentStackView.addArrangedSubviews(rowView) |
Collaborator
There was a problem hiding this comment.
addArrangedSubviews 대신 addArrangedSubview를 호출해도 되겠네요! 밑에 divider를 추가할 때도요!
| guard let tappedView = tapRecognizer.view else { return } | ||
|
|
||
| switch tappedView.tag { | ||
| case 0: |
Collaborator
There was a problem hiding this comment.
tag에 따라 분기 처리하기보다 만들어둔 CommonQuestArchiveType에 액션 케이스를 정의해주면 어떨까요? 대충 작성해보자면..
enum CommonQuestArchiveType {
case mine
case other
enum Action {
case edit, delete, report, block // 차례대로 수정, 삭제, 신고, 차단
}
struct Item {
let title: String
let icon: UIImage
let color: UIColor
let action: Action // 새로운 속성 추가
}
...
}이런 식으로 만들어서 switch-case문 없이 sheetType의 Item의 action에 접근하도록 설계할 수도 있을 것 같아요~
Collaborator
Author
There was a problem hiding this comment.
action에 접근해서 case에 따라 분기처리하는 방식으로 수정해보았습니다 !!!
juri123123
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
예시로 그냥 이 뷰에서 실행해봤어요.. ㅎㅎ
💻 주요 코드 설명
바텀시트
공통여정 아카이브가 내가 작성한 퀘스트 & 남이 작성한 퀘스트 두가지로 나뉘어져서, mine과 others 라는 enum으로 구분합니다.
확장성 있게 구현해보고 싶어서 .. Item 구조체를 만들어서, 바텀시트 뷰에서 makeItem을 호출해서 뷰에 넣는 식으로 구현했습니다.
이 부분에서 바텀시트를 사용할 때는 다음과 같이 부르면 됩니다!!