Merged
Conversation
1 task
y-eonee
approved these changes
Feb 24, 2026
Comment on lines
+210
to
212
| private static func makeTopRightButtonItem( | ||
| image: UIImage, | ||
| target: BaseViewController, |
| getUserNameUseCase.execute() | ||
| } | ||
|
|
||
| private static func stub() -> [AnswerRecord] { |
Collaborator
There was a problem hiding this comment.
stub은 나중에 유스케이스/레포지토리 생기면 분리하실 생각 있으신가요!?
Collaborator
Author
There was a problem hiding this comment.
네 추후 API 연동 때 분리합니다!
| return [ | ||
| .init( | ||
| question: "이별 후 제일 힘들었던 순간은?", | ||
| answer: "헤어진 첫날 밤이었어요. 혼자 집에 있는데 갑자기 모든 게 현실로 다가왔고, 이제 정말 끝났", |
Comment on lines
+72
to
+79
| let historyViewController = ViewControllerFactory.shared.makeCommonQuestHistoryViewController() | ||
| historyViewController.navigationItem.hidesBackButton = true | ||
| historyViewController.configure( | ||
| question: record.question, | ||
| writtenAt: record.writtenAt, | ||
| profileIcon: .sosoBadge, | ||
| nickname: viewModel.getUserName(), | ||
| content: record.answer |
Collaborator
There was a problem hiding this comment.
근데 내답변 보기 할 때는 프로필 아이콘이 없어야 하지 않나요?!
juri123123
approved these changes
Feb 26, 2026
|
|
||
| enum NavigationBarType: Equatable { | ||
| case back(header: NavigationHeaderType = .clear) | ||
| case backAndMenu(header: NavigationHeaderType = .clear) |
Collaborator
There was a problem hiding this comment.
jw 이거 case 순서 기준이 있는거에용?
Collaborator
Author
There was a problem hiding this comment.
아 back에서 파생(?)된 느낌이라 2번째로 배치했는데, 딱히 상관없어요! ㅎㅎ 마지막으로 빼도 됩니다
Comment on lines
+15
to
+19
| struct AnswerRecord { | ||
| let question: String | ||
| let answer: String | ||
| let writtenAt: Date | ||
| } |
Collaborator
There was a problem hiding this comment.
얘도 viewmodel에서만 사용되는 친구일까용 . . .? API 연동 시에 분리할 예정이신가요 ? ?
Comment on lines
+56
to
+58
| $0.register(CommonQuestAnswerCell.self) | ||
| $0.register(CommonQuestContentCell.self) | ||
| $0.register(NoAnswerCell.self) |
Comment on lines
+81
to
+83
| private func moveWriteAnswerButtonDidTap() { | ||
|
|
||
| } |
Comment on lines
+72
to
+79
| let historyViewController = ViewControllerFactory.shared.makeCommonQuestHistoryViewController() | ||
| historyViewController.navigationItem.hidesBackButton = true | ||
| historyViewController.configure( | ||
| question: record.question, | ||
| writtenAt: record.writtenAt, | ||
| profileIcon: .sosoBadge, | ||
| nickname: viewModel.getUserName(), | ||
| content: record.answer |
Comment on lines
+89
to
+94
| func tableView( | ||
| _ tableView: UITableView, | ||
| viewForHeaderInSection section: Int | ||
| ) -> UIView? { | ||
| UIView() | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
테이블뷰 셀 간 간격을 주어야 하는데, 셀에 빈 헤더를 넣어서 간격이 떨어져있는 것처럼 보이게 만드는 작전입니당
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
💻 주요 코드 설명