Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 6238 prevents compilation #6596

Closed
Firstyear opened this issue Feb 7, 2025 · 0 comments · Fixed by #6597
Closed

Regression in 6238 prevents compilation #6596

Firstyear opened this issue Feb 7, 2025 · 0 comments · Fixed by #6597
Assignees
@Firstyear
Labels
needs triage The issue will be triaged during scrum

Comments

@Firstyear
Copy link
Contributor

#6238 uses a C syntax that may only be available in C17, which causes this compiler error in older gcc versions.

[  160s] ldap/servers/slapd/auditlog.c: In function 'write_audit_file_json':
[  160s] ldap/servers/slapd/auditlog.c:460:13: error: a label can only be part of a statement and a declaration is not a statement
[  160s]              json_object *mod_list = json_object_new_array();
[  160s]              ^~~~~~~~~~~
[  160s] ldap/servers/slapd/auditlog.c:516:13: error: a label can only be part of a statement and a declaration is not a statement
[  160s]              int len;
[  160s]              ^~~
@Firstyear Firstyear added the needs triage The issue will be triaged during scrum label Feb 7, 2025
@Firstyear Firstyear self-assigned this Feb 7, 2025
@Firstyear Firstyear mentioned this issue Feb 7, 2025
Merged
Firstyear added a commit to Firstyear/389-ds-base that referenced this issue Feb 7, 2025
@Firstyear
Issue 6596 - BUG - Compilation Regresion
9b5eac0 
Bug Description: The addition of the json auditlog feature caused
a regresion in compilation due to the use of labels in a declaration.

Fix Description: Enclose the switch/case in braces to resolve the
compilation issue.

fixes: 389ds#6596

Author: William Brown <[email protected]>

Review by: ???
Firstyear added a commit to Firstyear/389-ds-base that referenced this issue Feb 7, 2025
@Firstyear
Issue 6596 - BUG - Compilation Regresion
d0f1cc0 
Bug Description: The addition of the json auditlog feature caused
a regresion in compilation due to the use of labels in a declaration.

Fix Description: Enclose the switch/case in braces to resolve the
compilation issue.

fixes: 389ds#6596

Author: William Brown <[email protected]>

Review by: ???
Firstyear added a commit that referenced this issue Feb 7, 2025
@Firstyear
Issue 6596 - BUG - Compilation Regresion (#6597)
58dc695 
Bug Description: The addition of the json auditlog feature caused
a regresion in compilation due to the use of labels in a declaration.

Fix Description: Enclose the switch/case in braces to resolve the
compilation issue.

fixes: #6596

Author: William Brown <[email protected]>

Review by: @droideck Thanks!
Firstyear added a commit that referenced this issue Feb 7, 2025
@Firstyear
Issue 6596 - BUG - Compilation Regresion (#6597)
e9e2482 
Bug Description: The addition of the json auditlog feature caused
a regresion in compilation due to the use of labels in a declaration.

Fix Description: Enclose the switch/case in braces to resolve the
compilation issue.

fixes: #6596

Author: William Brown <[email protected]>

Review by: @droideck Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Firstyear Firstyear

Labels
needs triage The issue will be triaged during scrum
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 6596 - BUG - Compilation Regresion Firstyear/389-ds-base
1 participant
@Firstyear