Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6596 - BUG - Compilation Regresion #6597

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Firstyear
Copy link
Contributor

Bug Description: The addition of the json auditlog feature caused a regresion in compilation due to the use of labels in a declaration.

Fix Description: Enclose the switch/case in braces to resolve the compilation issue.

fixes: #6596

Author: William Brown [email protected]

Review by: ???

@Firstyear
Copy link
Contributor Author

Requires backport to 3.0 and 2.5

Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Should we also add the same for SLAPI_OPERATION_DELETE and SLAPI_OPERATION_MODDN cases? Even though it's not required but for consistency it'll be nice

Bug Description: The addition of the json auditlog feature caused
a regresion in compilation due to the use of labels in a declaration.

Fix Description: Enclose the switch/case in braces to resolve the
compilation issue.

fixes: 389ds#6596

Author: William Brown <[email protected]>

Review by: ???
@Firstyear Firstyear force-pushed the 20250207-6596-compilation-issue branch from 9b5eac0 to d0f1cc0 Compare February 7, 2025 04:21
@Firstyear
Copy link
Contributor Author

Easy, done!

@Firstyear Firstyear merged commit 042f7c9 into 389ds:main Feb 7, 2025
9 checks passed
@Firstyear Firstyear deleted the 20250207-6596-compilation-issue branch February 7, 2025 04:47
Firstyear added a commit that referenced this pull request Feb 7, 2025
Bug Description: The addition of the json auditlog feature caused
a regresion in compilation due to the use of labels in a declaration.

Fix Description: Enclose the switch/case in braces to resolve the
compilation issue.

fixes: #6596

Author: William Brown <[email protected]>

Review by: @droideck Thanks!
Firstyear added a commit that referenced this pull request Feb 7, 2025
Bug Description: The addition of the json auditlog feature caused
a regresion in compilation due to the use of labels in a declaration.

Fix Description: Enclose the switch/case in braces to resolve the
compilation issue.

fixes: #6596

Author: William Brown <[email protected]>

Review by: @droideck Thanks!
@Firstyear
Copy link
Contributor Author

   66fde4d66..58dc695ca  389-ds-base-2.5 -> 389-ds-base-2.5
   54719e750..e9e24825f  389-ds-base-3.0 -> 389-ds-base-3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 6238 prevents compilation
2 participants