Issue #6562 - Prevent undefined behaviour in in filter_stuff_func #6563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Description: Undefined behaviour caused by escaping null character. Fix Description: Add simple check when ldap_bv2escaped_filter_value return null terminator. relates: 389ds#6562 Reviewed by: ???
|
I guess there's much better solution than this. Like adding check right after function signature or making wrapper for ldap_bv2escaped_filter_value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description:
Undefined behaviour caused by escaping null character.
Fix Description:
Add simple check when ldap_bv2escaped_filter_value return null terminator which return error.
relates: #6562
Reviewed by: ???