Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6583 - Fix CI on older branches - 1.4.3 #6584

Open
wants to merge 1 commit into
base: 389-ds-base-1.4.3
Choose a base branch
from

Conversation

vashirov
Copy link
Member

@vashirov vashirov commented Feb 5, 2025

Bug Description:
Test execution on older branches (1.4.x, some 2.x) fails. We use the same Fedora base image across all branches, but it contains newer toolchain and doesn't have some build dependencies.

Fix Description:
Use appropriate images: EL8 for 1.4.x, EL9 for 2.x, EL10/Fedora for 3.x.

Fixes: #6583

@vashirov vashirov changed the title Issue 6583 - Fix CI on older branches Issue 6583 - Fix CI on older branches - 1.4.3 Feb 5, 2025
Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@progier389
Copy link
Contributor

Maybe we should also disable C Lang builds that fails (I do not think that they are really useful for rhel 8 tests)

@vashirov
Copy link
Member Author

vashirov commented Feb 5, 2025

Right, I think the whole Compile action can be disabled for older branches.

Bug Description:
Test execution on older branches (1.4.x, some 2.x) fails. We use the
same Fedora base image across all branches, but it contains newer
toolchain and doesn't have some build dependencies.

Fix Description:
Use appropriate images: EL8 for 1.4.x, EL9 for 2.x, EL10/Fedora for 3.x.

Fixes: 389ds#6583

Reviewed by: @progier389 (Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants