Issue 6583 - Fix CI on older branches - 1.4.4 #6586
Draft
+446
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vashirov
changed the title
Description: Run cargo update --manifest-path=./src/Cargo.toml. Add minimum supported rust version field to the manifests. Fix minor 'variable does not need to be mutable' error. Another error: error: using `.borrow()` on a double reference, which returns `&concread::cowcell::CowCellReadTxn<CacheStats>` instead of borrowing the inner type We're getting the error about borrowing a double reference because we're trying to borrow a type that is already a reference. Fix - use the type directly. Set rust-version to 1.70 for better compatibility. Related: 389ds#5853 Fixes: 389ds#5861 Reviewed by: @vashirov (Thanks!), @Firstyear (Thanks for the rust-version idea!)
Bug Description: Test execution on older branches (1.4.x, some 2.x) fails. We use the same Fedora base image across all branches, but it contains newer toolchain and doesn't have some build dependencies. Fix Description: Use appropriate images: EL8 for 1.4.x, EL9 for 2.x, EL10/Fedora for 3.x. Fixes: 389ds#6583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description:
Test execution on older branches (1.4.x, some 2.x) fails. We use the same Fedora base image across all branches, but it contains newer toolchain and doesn't have some build dependencies.
Fix Description:
Use appropriate images: EL8 for 1.4.x, EL9 for 2.x, EL10/Fedora for 3.x.
Fixes: #6583