Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 6599 - Implement option to write access log in JSON #6600

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Issue 6599 - Implement option to write access log in JSON #6600

merged 1 commit into from
Feb 12, 2025

Conversation

mreynolds389
Copy link
Contributor

Description:

Add option to write access log in JSON

Relates: #6599

@mreynolds389 mreynolds389 changed the title Issue 6599 - Implement option to write access log in jSON Issue 6599 - Implement option to write access log in JSON Feb 10, 2025
@mreynolds389
Copy link
Contributor Author

Design doc:

https://www.port389.org/docs/389ds/design/accesslog-json-design.html

@mreynolds389 mreynolds389 force-pushed the access_json_2 branch 2 times, most recently from f3a0c40 to 58c5b17 Compare February 11, 2025 15:42
progier389
progier389 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
The only doubt I have is about the copyrights,
I was thinking that now we tend to keep a single year for RH copyright , but I may be wrong ...

@mreynolds389
Copy link
Contributor Author

LGTM, The only doubt I have is about the copyrights, I was thinking that now we tend to keep a single year for RH copyright , but I may be wrong ...

On IPA they use this range approach. I recall it following some "standard", but I'm not really sure. Let me look into that...

@mreynolds389
Copy link
Contributor Author

LGTM, The only doubt I have is about the copyrights, I was thinking that now we tend to keep a single year for RH copyright , but I may be wrong ...

On IPA they use this range approach. I recall it following some "standard", but I'm not really sure. Let me look into that...

Not really seeing anything concrete on the matter. Seems ranges, or lists are common, but not required. Ultimately the result is the same as long as it has the current year. So I'll change it back to a single year as I don't have a strong option on it.

@jchapma
Copy link
Contributor

jchapma commented Feb 12, 2025

I had a good play around with this, works great for me. It is going to make logconv's job a lot easier.

@mreynolds389
Issue 6599 - Implement option to write access log in jSON
cde2379 
Description:

Add option to write access log in JSON

See design doc for more info:

https://www.port389.org/docs/389ds/design/accesslog-json-design.html

Relates: 389ds#6599

Reviewed by: progier & jchapman(Thanks!!)
@mreynolds389 mreynolds389 merged commit 699f30e into 389ds:main Feb 12, 2025
9 checks passed
@mreynolds389 mreynolds389 deleted the access_json_2 branch February 12, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@progier389 progier389 progier389 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mreynolds389 @jchapma @progier389