Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6625 - UI - fix various issues with LDAP browser, etc #6627

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

mreynolds389
Copy link
Contributor

Description:

Fixed these issues

  • Creating OU in ldap browser ends in error
  • Delete MemberOf Config Entry window does not close when you delete the shared config entry of MemberOf
  • Message about enabling any plugin is missing result
  • WebUI tries to load non-existent vendor-react.js
  • Missing word in success alert when changing replica role
  • Incomplete word after restarting an instance
  • Broken formatting and unclear descriprion when trying a DN rename
  • Confusing confirmation message upon deletion of an entry
  • Unclear message when trying to create entry with duplicate DN
  • Cannot go back in dialog when creating an entry encounters an error

Relates: #6625

@jchapma
Copy link
Contributor

jchapma commented Feb 19, 2025

All the items in the list above work fine for me, apart from the final two:

  • Unclear message when trying to create entry with duplicate DN
  • Cannot go back in dialog when creating an entry encounters an error

When adding a user, selecting the user type results in an oops:

Select.tsx:399 Uncaught TypeError: onToggle is not a function
    at onToggle (Select.tsx:399:5)
    at onClick (SelectToggle.tsx:301:15)
    at HTMLUnknownElement.callCallback2 (

I don't think the problem is related to this PR though, maybe the move to PF5. What confuses me is that creating a new group works fine, which uses the same structure. My package.json contains the PF5 updates. Any ideas ?

@mreynolds389
Copy link
Contributor Author

mreynolds389 commented Feb 19, 2025

All the items in the list above work fine for me, apart from the final two:

  • Unclear message when trying to create entry with duplicate DN

This is working for me. Instead of a plain "error 68" it now says: Failed to add entry: ldap_add: Already exists (68)

Note this is lib389/dsconf returning the error. I was not planning on creating friendly error messages for all 90+ ldap error codes, and regardless that would be done in lib389 not the web UI

  • Cannot go back in dialog when creating an entry encounters an error

I can go back when an error occurs. What is your test case?

@mreynolds389
Copy link
Contributor Author

When adding a user, selecting the user type results in an oops:

Select.tsx:399 Uncaught TypeError: onToggle is not a function
    at onToggle (Select.tsx:399:5)
    at onClick (SelectToggle.tsx:301:15)
    at HTMLUnknownElement.callCallback2 (

Correct this is a separate issue unrelated to my PR. I'll fix this in my next round of UI fixes.

@jchapma
Copy link
Contributor

jchapma commented Feb 19, 2025

All the items in the list above work fine for me, apart from the final two:

  • Unclear message when trying to create entry with duplicate DN

This is working for me. Instead of a plain "error 68" it now says: Failed to add entry: ldap_add: Already exists (68)
Note this is lib389/dsconf returning the error. I was not planning on creating friendly error messages for all 90+ ldap error codes, and regardless that would be done in lib389 not the web UI

It also works for me when I add a duplicate group, I think "already exists" is fine. Its the adding a user that fails, but thats in hand.

  • Cannot go back in dialog when creating an entry encounters an error

I can go back when an error occurs. What is your test case?

This does work for me when I add a duplicate group, it was the adding of a new user that confused me. But as its a separate issue we can approve this PR. Thanks

Copy link
Contributor

@jchapma jchapma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreynolds389
Copy link
Contributor Author

  • Cannot go back in dialog when creating an entry encounters an error

I can go back when an error occurs. What is your test case?

This does work for me when I add a duplicate group, it was the adding of a new user that confused me. But as its a separate issue we can approve this PR.

What issue? I can go back when adding a group, or user, fails. Please clarify what you are doing that won't allow you to go back.

@mreynolds389
Copy link
Contributor Author

  • Cannot go back in dialog when creating an entry encounters an error

I can go back when an error occurs. What is your test case?

This does work for me when I add a duplicate group, it was the adding of a new user that confused me. But as its a separate issue we can approve this PR.

What issue? I can go back when adding a group, or user, fails. Please clarify what you are doing that won't allow you to go back.

Now I do get a browser crash when going back after a group add fails. I'm going to work on that now...

@jchapma
Copy link
Contributor

jchapma commented Feb 19, 2025

  • Cannot go back in dialog when creating an entry encounters an error

I can go back when an error occurs. What is your test case?

This does work for me when I add a duplicate group, it was the adding of a new user that confused me. But as its a separate issue we can approve this PR.

What issue? I can go back when adding a group, or user, fails. Please clarify what you are doing that won't allow you to go back.

I can also go back when the addition of a duplicate group or user fails, it works fine.

The separate issue I mentioned was the oops generated during selection of user type when creating a new user, but its nothing to do with this PR.

Description:

Fixed these issues

- Creating OU in ldap browser ends in error
- Delete MemberOf Config Entry window does not close when you delete the shared
  config entry of MemberOf
- Message about enabling any plugin is missing result
- WebUI tries to load non-existent vendor-react.js
- Missing word in success alert when changing replica role
- Incomplete word after restarting an instance
- Broken formatting and unclear descriprion when trying a DN rename
- Confusing confirmation message upon deletion of an entry
- Unclear message when trying to create entry with duplicate DN
- Cannot go back in dialog when creating an entry encounters an error

Relates: 389ds#6625

Reviewed by: jchapamn (Thanks!)
@mreynolds389
Copy link
Contributor Author

  • Cannot go back in dialog when creating an entry encounters an error

I can go back when an error occurs. What is your test case?

This does work for me when I add a duplicate group, it was the adding of a new user that confused me. But as its a separate issue we can approve this PR.

What issue? I can go back when adding a group, or user, fails. Please clarify what you are doing that won't allow you to go back.

I can also go back when the addition of a duplicate group or user fails, it works fine.

The separate issue I mentioned was the oops generated during selection of user type when creating a new user, but its nothing to do with this PR.

Gotcha, thanks. Merging...

@mreynolds389 mreynolds389 merged commit e0e59f9 into 389ds:main Feb 19, 2025
8 of 9 checks passed
@mreynolds389 mreynolds389 deleted the webui_part1 branch February 19, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants