-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 6625 - UI - fix various issues with LDAP browser, etc #6627
Conversation
All the items in the list above work fine for me, apart from the final two:
When adding a user, selecting the user type results in an oops:
I don't think the problem is related to this PR though, maybe the move to PF5. What confuses me is that creating a new group works fine, which uses the same structure. My package.json contains the PF5 updates. Any ideas ? |
This is working for me. Instead of a plain "error 68" it now says: Failed to add entry: ldap_add: Already exists (68) Note this is lib389/dsconf returning the error. I was not planning on creating friendly error messages for all 90+ ldap error codes, and regardless that would be done in lib389 not the web UI
I can go back when an error occurs. What is your test case? |
Correct this is a separate issue unrelated to my PR. I'll fix this in my next round of UI fixes. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What issue? I can go back when adding a group, or user, fails. Please clarify what you are doing that won't allow you to go back. |
Now I do get a browser crash when going back after a group add fails. I'm going to work on that now... |
I can also go back when the addition of a duplicate group or user fails, it works fine. The separate issue I mentioned was the oops generated during selection of user type when creating a new user, but its nothing to do with this PR. |
Description: Fixed these issues - Creating OU in ldap browser ends in error - Delete MemberOf Config Entry window does not close when you delete the shared config entry of MemberOf - Message about enabling any plugin is missing result - WebUI tries to load non-existent vendor-react.js - Missing word in success alert when changing replica role - Incomplete word after restarting an instance - Broken formatting and unclear descriprion when trying a DN rename - Confusing confirmation message upon deletion of an entry - Unclear message when trying to create entry with duplicate DN - Cannot go back in dialog when creating an entry encounters an error Relates: 389ds#6625 Reviewed by: jchapamn (Thanks!)
162e0ed
to
bfd6b9d
Compare
Gotcha, thanks. Merging... |
Description:
Fixed these issues
Relates: #6625