-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace device library with an alternative #5427
Labels
Milestone
Comments
@carmenfan I'd be happy to work on this 😊 |
Hi @jacobcons This is a piece of work I carved out for an internal member to keep them busy whilst I sort out other things. Thank you for offering though! |
@carmenfan No worries at all! I updated this pr #5390 to have full test coverage btw. Would love to get your thoughts when you have a chance, no worries if things are very busy. |
Bogdan-Crn
added a commit
that referenced
this issue
Mar 26, 2025
carmenfan
added a commit
that referenced
this issue
Mar 26, 2025
carmenfan
added a commit
that referenced
this issue
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
We're using device library to determine what is the device used by the user logging in through the useragent. This seems to be an abandoned project (last updated 5 years ago), and it has a dependecy on useragent which is another abandoned project that we've replaced in #5239.
Suggested solution
We want to use something that is more up to date to make sure we're protected against vunerability and provide us with up to date results, a quick google points me to https://www.npmjs.com/package/node-device-detector but there may be other options too.
Goal
Tasks
TBC by the developer
The text was updated successfully, but these errors were encountered: