Issue 5427 - Replace device library with an alternative #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenfan
previously approved these changes
Mar 26, 2025
backend/package.json
Outdated
| @@ -60,6 +59,7 @@ | |||
| "moment-timezone": "0.5.45", | |||
| "mongodb": "3.7.4", | |||
| "multer": "1.4.5-lts.1", | |||
| "node-device-detector": "^2.2.0", | |||
There was a problem hiding this comment.
can we lock down the version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5427
Description
Replaced the old device library with with node-device-detector.
Test cases
Updated the userAgent tests as well to reflect that the default response has changed and to add a test for smartphone access.