Issue #4973 Upgrade viewer specific APIs to v5 #5362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssociated tests
… actually a noFile revision.
…m already existing in the v5 typeCheck file. Replaced where used.
…aces to serviceHelper
…alisation since binFacesString is inaccessible and only called by it.
…t was discovered while writing unit tests
…des since they are never used.
…query parameter
…uery parameters
…its legacy character.
…ting is currently unavailable
…d modelProperties
|
The routes are now renamed and revision information has been put into the query string. |
|
I have updated the description of the PR with the changed routes and the new one added (bundleMappings). |
… and federation info to the unity viewer
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Viewer PR: Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4973
Description
Moves over v4 APIs that are used by the viewer to the v5 style.
Changed APIs listed below:
(Note: routes below updated after receiving feedback)
Get Model Properties:
Old API:
/<teamspace>/<modelID>/revision/<revision>/modelProperties.jsonNew API (Container):
/v5/teamspaces/<teamspace>/projects/<projectID>/containers/<containerID>/assets/propertiesNew API (Federation):
/v5/teamspaces/<teamspace>/projects/<projectID>/federations/<containerID>/assets/propertiesGet Repo Assets:
Old API:
/<teamspace>/<modelID>/revision/<revision>/repoAssets.jsonNew API (Container):
/v5/teamspaces/<teamspace>/projects/<projectID>/containers/<containerID>/assets/repobundlesNew API (Federation):
/v5/teamspaces/<teamspace>/projects/<projectID>/federations/<containerID>/assets/repobundlesGet Metadata (assets meta)
Old API:
/<teamspace>/<modelID>/revision/<revision>/assetsMetaNew API (Container)
/v5/teamspaces/<teamspace>/projects/<projectID>/containers/<containerID>/assets/legacyBundleMetadataNew API (Federation):
/v5/teamspaces/<teamspace>/projects/<projectID>/federations/<containerID>/assets/legacyBundleMetadataGet Mesh
Old API:
/<teamspace>/<modelID>/meshes/<meshID>New API (Container):
/v5/teamspaces/<teamspace>/projects/<projectID>/containers/<containerID>/assets/meshes/:meshIdGet Unity Asset Bundle
Old API:
/<teamspace>/<modelID>/<bundleID>.unity3dNew API (Container):
/v5/teamspaces/<teamspace>/projects/<projectID>/containers/<containerID>/assets/unitybundles/<bundleID>Get Repo Asset Bundle:
Old API:
/<teamspace>/<modelID>/<bundleID>.repobundleNew API (Container):
/v5/teamspaces/<teamspace>/projects/<projectID>/containers/<containerID>/assets/repobundles/<bundleID>Get Asset Maps for Container
Old API:
/<teamspace>/<containerID>/revision/<revisionID>/supermeshes.json.mpcNew API (Container):
/v5/teamspaces/<teamspace>/projects/<projectID>/containers/<containerID>/assets/supermeshes/v5/teamspaces/<teamspace>/projects/<projectID>/containers/<containerID>/assets/supermeshesGet Asset Maps for Federation
Old API:
/<teamspace>/<modelID>/revision/master/head/supermeshes.json.mpcNew API (Federation):
/v5/teamspaces/<teamspace>/projects/<projectID>/federations/<federationID>//assets/supermeshesGet Texture:
Old API:
/<teamspace>/<containerID>/<textureID>.textureNew API (Container):
/v5/teamspaces/<teamspace>/projects/<projectID>/containers/<containerID>/assets/textures/<textureID>Get bundle mapping:
Old API:
/<teamspace>/<modelID>/<bundleID>.json.mpcNew API (Container):
/v5/teamspaces/<teamspace>/projects/<projectID>/containers/<containerID>/assets/bundleMappings/<bundleID>Test cases