Issue 5339 - Multiple jobs support #5377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
route / processor / model methods for adding, edititng, removing jobs added documentation added
script to givce jobs names started
users ts access check
middleware unit tests added
add/update/delete role e2e tests added e2e test fixes
carmenfan
requested changes
Feb 4, 2025
carmenfan
requested changes
Mar 25, 2025
There was a problem hiding this comment.
As discussed, we need to consider #5356 for this.
We want to instead migrate to frontegg to store our roles in their groups (so for e.g. if a new role is created, we call this : https://developers.frontegg.com/api/identity/user-groups/groupscontrollerv1_creategroup)
So edit and update should be going through frontegg (sorry 😢 🙈 )
| if (!existingRolesMap[job._id]) { | ||
| const role = { ...job, name: job._id, _id: generateUUID() }; | ||
| newRoles.push(role); | ||
| roleNamesToIds[role.name] = role._id; |
There was a problem hiding this comment.
Can we also add existing entries to roleNamesToId?
Just incase the script died in the middle and managed to add the roles but didn't update tickets/issues etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5339
Description
Jobs are renamed to roles and have UUID ids and name
Migration script for updating issues, risks, tickets, templates and ticket logs added
Users can now be asssigned to multiple roles
Endpoints for creating / updating / deleting a role added
Respective v4 endpoints removed and an appropriate response is returned
Swagger documentation added
Unit and e2e tests added
Test cases
Migration script should run and update all necessary collections
Users should be able to create/update/delete a role using v5 endpoints
Old v4 endpoints should return appropriate error and point to the new endpoints