Skip to content

Issue 5311 - Add/remove columns in tickets table #5402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 72 commits into from
May 21, 2025
Merged

Conversation

Amantini1997
Copy link
Contributor

@Amantini1997 Amantini1997 commented Feb 13, 2025

This fixes #5311

Description

  • This template enhanced tickets table to show ALL the all the properties (that can be rendered as a text) from a given template (previously it was only some specific ones);
  • Because of the previous point, all the tickets are fetched in full (previously, only the necessary properties were fetched), so that the tickets display the values for each filled property;
  • There is now a feature to show/hide columns: a gear (rendered at the end of the columns headers) acts as a trigger for a dropdown menu listing all the template properties. To improve the UX, checking/unchecking a property from that list will show/hide the respective column in real time, but the modal will not move.

Bug(gish) behaviour

  • The search feature does not work well. This is, however, acceptable as such a feature will be ditched with the new filtering system that is currently being brought to tabular view.
  • Some safetibase properties were using special chips instead of plain text. This behaviour was intentionally changed to create consistency.

Test cases

Change template:

  • the table should stretch to fit the screen;
  • all the available columns (that have not been hidden by the user) should be available;
  • the width of the new columns should be the default one, whereas the already available columns should keep the same width (unless a stretch takes place)
  • switching to a new template that has all its columns hidden should show the id column

Change grouping options:

  • the columns visibility and width shouldn't change

Change some ticket properties values:

  • the columns visibility and width shouldn't change

Click the gear icon and:

  • check/uncheck some properties. The respective column should show/hide;
  • change a column width (remember this width, let's call it "Width A"), then hide and show again that column. The width should not change due to the hide and show flow (Width A).

Base automatically changed from ISSUE_5310 to staging February 14, 2025 16:09
@carmenfan
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Amantini1997
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Didi-Kwan
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

@Didi-Kwan Didi-Kwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2 testing is complete. Here is the updated test summary report.

Didi-Kwan
Didi-Kwan previously approved these changes May 6, 2025
Copy link

@Didi-Kwan Didi-Kwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 3 testing is complete. It's good to go now :) Here is the updated test summary report.

sanmont3drepo
sanmont3drepo previously approved these changes May 15, 2025
@sanmont3drepo
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@carmenfan carmenfan merged commit e0791e2 into staging May 21, 2025
20 of 24 checks passed
@carmenfan carmenfan deleted the ISSUE_5311 branch May 21, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants