Issue 5421 - Tickets: Optional clear button #5436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
The-Daniel
requested changes
Mar 11, 2025
frontend/src/v5/ui/routes/viewer/tickets/ticketsForm/properties/oneOfProperty.component.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
We've lost the capitalisation of the values in issues/safetibase (the v4 card)
This PR:
Staging:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5421
Description
The "clear button" should only be available for non-required, editable values.
Note that, as part of the issue, the assignees value is no longer editable from the tickets list.
In order to render the clear value button in oneOf/manyOf at the end of the input, I had to fix an existing problem in the theme where the select input was getting the same style (border and box-shadow) twice. This impacted also v4 components, hence the refactoring.
Test cases
Try and clear the value for oneOf/manyOf properties across a ticket. If the field is editable and not required, that should be possible.
Try and edit/clear the value of assignees from the ticket preview item. That should not be possible
Try and edit/clear the value of assignees from the expanded ticket. That should be possible
Test v4 dropwdowns components. The functionality and the outlook should not be different