Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE #5490 - Moved filters fetch to filters setter so that the tickets are available on model load #5491

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sanmont3drepo
Copy link
Contributor

@sanmont3drepo sanmont3drepo commented Apr 7, 2025

This fixes #5490

Description

  • When the model is loading the ticket cards is not opened necessary opened. The fetch of filtered tickets was triggerered in that component , so that was moved to a component that is rendered in the viewer (DefaultTicketFiltersSetter)
  • DefaultTicketFiltersSetter got renamed to TicketFiltersSetter
  • TicketFiltersSetter now sets the filter for ticket codes based on url

Test cases

  • Enter a model with pins from tickets, without opening the pins card the pins should be shown
  • The pins should be from the tickets that matches de default criteria (no closed pins, etc)
  • Email url should work; the param for url emails is ?ticketSearch={ticketType}:{ticketNumber},{ticketType}:{ticketNumber},... for example /v5/viewer/teamSpace1/7b11d960-9b36-11ed-b559-0768f95e09ad/904de26e-feb9-446f-94e2-db4bd4a7610f?ticketSearch=ILT:1,PIN:1,VPT:2 . Once the user has navigated to the url the param gets cleared and the ticket card is opened with the filtered tickets especified in the url.

@carmenfan
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@carmenfan carmenfan requested a review from Didi-Kwan April 7, 2025 16:16
@carmenfan carmenfan assigned Didi-Kwan and unassigned Amantini1997 Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pins not showing on load
4 participants