Header - Add authenticated user organization in hidden fields #5288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sigavignon |
Gustry
added
sponsored development
|
@Gustry thanks a lot for the tests. Do you think we should also add other fields (city, postcode, etc.) ? |
|
If more are added, I would prefer something cleaner (and revert your change in the first commit), using data attributes ? I'm curious what other websites do ? Do they expose all "sensible" data into the frontend ? (with extensions, plugins ...) |
|
@mdouchin this data could be exposed through jsvars, like dataviz, action, filter, isn't it ? |
|
Way more comfortable to use |
rldhont
approved these changes
Jan 31, 2025
Gustry
force-pushed
the
mdouchin-headermenu-add-organization-in-hidden-fields
branch
from
8fc5cfe to
0513e4e
Compare
This allows a JavaScript script to get the current user organization and use it in the editing form.
Gustry
force-pushed
the
mdouchin-headermenu-add-organization-in-hidden-fields
branch
from
0513e4e to
9c444a5
Compare
Read onlySummary
Flaky Tests
🔄 This comment has been updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a JavaScript script to get the current user organization and use it in the editing form.
Ticket : #
Funded by Ville d'Avignon https://cartes.mairie-avignon.com