Skip to content

feat(iac-deploy): Create reusable workflow for iac deployments #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 3, 2025

Conversation

chris3ware
Copy link
Member

@chris3ware chris3ware commented Mar 26, 2025

The purpose of this workflow is to create a plan comment in the pull request and apply, via merge queue on merge.

Successful applies will trigger code promotion, where the workflow can be called again to apply to a different environment.

The environment is provided via an input.

@chris3ware chris3ware requested a review from a team as a code owner March 26, 2025 09:27
Copy link
Contributor

github-actions bot commented Mar 26, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/cache 5a3ec84eff668545956fd18022155c47e93e2684 🟢 7.1
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 1026 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 10no binaries found in the repo
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Security-Policy🟢 9security policy file detected
SAST🟢 10SAST tool is run on all commits
Vulnerabilities🟢 91 existing vulnerabilities detected
actions/actions/checkout 11bd71901bbe5b1630ceea73d27597364c9af683 🟢 5.9
Details
CheckScoreReason
Maintained⚠️ 22 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 2
Code-Review🟢 10all changesets reviewed
Binary-Artifacts🟢 10no binaries found in the repo
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
Packaging🟢 10packaging workflow detected
SAST🟢 9SAST tool detected but not run on all commits
Vulnerabilities⚠️ 28 existing vulnerabilities detected
actions/aws-actions/configure-aws-credentials e3dd6a429d7300a6a4c196c26e071d42e0343502 🟢 5.6
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 1029 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 5Found 9/18 approved changesets -- score normalized to 5
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Security-Policy🟢 10security policy file detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Vulnerabilities🟢 64 existing vulnerabilities detected
actions/op5dev/tf-via-pr f455e10e6e83d28f53f505a2d8242433a17536f3 UnknownUnknown
actions/opentofu/setup-opentofu 592200bd4b9bbf4772ace78f887668b1aee8f716 🟢 4.8
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Maintained⚠️ 21 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 2
Code-Review🟢 9Found 11/12 approved changesets -- score normalized to 9
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Packaging⚠️ -1packaging workflow not detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Fuzzing⚠️ 0project is not fuzzed
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Vulnerabilities🟢 91 existing vulnerabilities detected
actions/terraform-linters/setup-tflint 15ef44638cb215296e7ba9e7a41f20b5b06f4784 🟢 5.1
Details
CheckScoreReason
Maintained🟢 1027 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Code-Review⚠️ 2Found 1/5 approved changesets -- score normalized to 2
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Security-Policy⚠️ 0security policy file not detected
Pinned-Dependencies🟢 10all dependencies are pinned
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 1branch protection is not maximal on development and all release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Vulnerabilities🟢 82 existing vulnerabilities detected
actions/tj-actions/changed-files c3a1bb2c992d77180ae65be6ae6c166cf40f857c 🟢 6.2
Details
CheckScoreReason
Security-Policy🟢 10security policy file detected
Code-Review⚠️ 0Found 1/14 approved changesets -- score normalized to 0
Maintained🟢 1030 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 10no binaries found in the repo
License🟢 10license file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Signed-Releases⚠️ -1no releases found
Fuzzing⚠️ 0project is not fuzzed
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Branch-Protection🟢 3branch protection is not maximal on development and all release branches
Pinned-Dependencies🟢 9dependency not pinned by hash detected -- score normalized to 9
SAST🟢 8SAST tool detected but not run on all commits
Vulnerabilities🟢 91 existing vulnerabilities detected

Scanned Files

  • .github/workflows/iac-deploy.yaml

Copy link
Contributor

github-actions bot commented Mar 26, 2025

Hi and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown scope "iac-deploy" found in pull request title "feat(iac-deploy): Create reusable workflow for iac deployments". Scope must match one of: checks, commitlint, delete-run, dep-review, get-token, pr-check, pr-title, ossf, release, renovate, terraform-dir, terraform-docs, trunk, workflows.

Please update the title to follow the conventional commit specification. If you need help, feel free to ask! 😊

@chris3ware
Copy link
Member Author

Hi and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown scope "iac-deploy" found in pull request title "feat(iac-deploy): Create reusable workflow for iac deployments". Scope must match one of: checks, commitlint, delete-run, dep-review, get-token, pr-check, pr-title, ossf, release, renovate, terraform-dir, terraform-docs, trunk, workflows.

Please update the title to follow the conventional commit specification. If you need help, feel free to ask! 😊

This can be ignored. The commit scope has been added to the commitlint config file in this PR

apply will also init so plugins will be pulled from cache
@james3ware
Copy link
Member

Successful plan and apply here: 3ware/aws-network-speciality#89

@chris3ware
Copy link
Member Author

Going to close this PR and raise another for code promotion

@james3ware james3ware merged commit 742f0f5 into main Apr 3, 2025
4 of 5 checks passed
@james3ware james3ware deleted the feat-iac-deploy branch April 3, 2025 13:49
3ware-release bot pushed a commit that referenced this pull request Apr 3, 2025
## [4.19.0](v4.18.0...v4.19.0) (2025-04-03)

### Features

* **iac-deploy:** Create reusable workflow for iac deployments ([#189](#189)) ([742f0f5](742f0f5))
@3ware-release
Copy link
Contributor

3ware-release bot commented Apr 3, 2025

This PR is included in version 4.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants