cypress basic 과제 제출 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyo-choi
reviewed
Jun 23, 2021
| it('doesn\'t increase over 12', () => { | ||
| cy.get('.plus-button').click() | ||
| .get('.count-display').should('have.value', 12); | ||
| cy.get('.plus-button').click().click().click() |
There was a problem hiding this comment.
이렇게 클릭만 여러 번 해서 테스팅하는 방법은 생각을 못 해봤는데 좋은 방법인 것 같아요! 배워갑니다 😄
Comment on lines
+18
to
21
| "scripts": { | ||
| "build": "yarn tsc --watch", | ||
| "test": "yarn cypress open" | ||
| } |
Comment on lines
+2
to
+3
| let countValue = 10; | ||
| let countDisplay: HTMLInputElement | null; |
There was a problem hiding this comment.
countValue와 countDisplay.value를 따로 다루신 이유가 있을까요?
CountDisplay 요소가 input 속성이라 요소의 value를 임의로 바꿀 수 있는데, 이 경우에는 변경된 값이 반영되지 않습니다. 이런 케이스에 대해서는 어떻게 생각하시는지 궁금합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.