Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update supported python versions and refine ci workflow #394

Merged
merged 9 commits into from
Sep 11, 2024

Conversation

c0state
Copy link
Contributor

@c0state c0state commented Sep 5, 2024

No description provided.


[gh-actions]
python =
3.9: py39-base, py39-full
3.10: py310-base, py310-full, lint, docs
3.10: py310
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox-gh-actions should run all envs of a given prefix:
https://github.com/ymyzk/tox-gh-actions#factor-conditional-settings-python-version

Copy link

@matt-m-mclaughlin matt-m-mclaughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c0state looks good, although dropping support for a python version may require a major version

@c0state
Copy link
Contributor Author

c0state commented Sep 11, 2024

@c0state looks good, although dropping support for a python version may require a major version

Hmm, maybe should add back?: edit: nvm, I think we can just cut a new release
https://devguide.python.org/versions/

3.9 still has a year left. Thought it was close to EOL or already EOL...

@c0state c0state merged commit 0b4a49c into master Sep 11, 2024
9 checks passed
@c0state c0state deleted the chore/update_ci_workfow branch September 11, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants