Allow to swap assets of any object type #7365
Conversation
| let smartObjectsCount = 0; | ||
| for (const type in assetPack.content) { | ||
| const assetCount = assetPack.content[type]; | ||
| if (!sortedContentType.includes(type)) { |
There was a problem hiding this comment.
It feels a bit light as a check to decide if the object is a smart object. If we add 3D particle emitters or 3D cubes in a pack, it will display them as a smart objects.
There was a problem hiding this comment.
If smart objects mean an object with some logic, it's the case for any object so I think it's not a big deal.
We can add lines for more objects in the future if we think it becomes useful.
I see it as a "others" category but less boring.
There was a problem hiding this comment.
But it's quite deceptive when users purchase something and they end up with boring objects.
There was a problem hiding this comment.
There is no easy way to know if an object comes from engine or an event-based extension. And even in this case, the limit is blurry because the 3D particle emitter is from an event-based extension and it may not fit everyone definition of "smart object".
I think when there are new cases, we can add specific lines for them.
The choice of words:
- "smart object" avoids diminishing the appeal for asset packs with custom objects (which is an actual use-case)
- "other" avoids the risk of mislabeling new objects (which rarely happens, is only a bug that can be fixed easily)
There was a problem hiding this comment.
Smart objects is probably fine. If some are becoming super "well known", we'll add specific names for them in the future.
Following steps