Add a warning on array children with inconsistent type #7376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ian
reviewed
Feb 6, 2025
| parentVariable && | ||
| parentVariable.getChildrenCount() > 1 && | ||
| parentVariable.getAtIndex(0).getType() !== type | ||
| ? i18n._(t`Array children must all be of the same type.`) |
There was a problem hiding this comment.
- "children" is better than "elements" in our case as it's how we call them.
- "must" is already stronger than "should" so I see no reason to change it.
- "for consistency" is just wrong, it's not about making it easier to understand, it's about making it work.
I think it's a good case of bad usage of AI. If you ask it to paraphrase it will, not always for the best.
There was a problem hiding this comment.
"All array children must be the same type".
then. My point was English phrasing ("XXX must all be of the same" ==> "All XXX must be the same type").
4ian
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gdevelop-storybook.s3.amazonaws.com/array-warn/latest/index.html?path=/story/variableslist--default