Fix a crash when searching instructions after extension are re-generated #7377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ian
force-pushed
the
fix/crash-changed-metadata
branch
3 times, most recently
from
5423d7c to
bd1646e
Compare
AlexandreSi
approved these changes
Feb 6, 2025
4ian
force-pushed
the
fix/crash-changed-metadata
branch
from
bd1646e to
890dc22
Compare
4ian
force-pushed
the
fix/crash-changed-metadata
branch
from
5dc4db0 to
63f94b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix risk of crash because reading ObjectMetadata or BehaviorMetadata that are C++ objects that could have been destroyed if extensions have finished being re-generated in the meantime.
Instead, store needed information only when the instructions are enumerated, so we don't risk accessing invalid C++ objects when a search is done.
Also update separator when showing results in UI:
