Add possibility to display message in the preview when an in-app tutorial is running #7379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AlexandreSi
commented
Feb 6, 2025
•
AlexandreSi
commented
4ian
reviewed
Feb 7, 2025
| @@ -0,0 +1,185 @@ | |||
| const redHeroImage = | |||
There was a problem hiding this comment.
Put this into the namespace, otherwise the esbuild transpilation will create this as a global variable.
(we're sadly not using modules)
4ian
reviewed
Feb 7, 2025
| </div> | ||
| </div> | ||
| ); | ||
| if (_container) domElementContainer.appendChild(_container); |
There was a problem hiding this comment.
it can't be null/undefined here, no?
4ian
reviewed
Feb 10, 2025
Comment on lines
+181
to
+182
| // @ts-ignore - TS doesn't acknowledge the assignation above that excludes | ||
| // the possibility that _container can be null. |
There was a problem hiding this comment.
You could try:
const container = (<div ...)
domElementContainer.appendChild(_container = container)
not sure if better, but at least avoids a ts-ignore
4ian
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.