TEST: Added backwards compatibility so parameterised tests work before and after phpunit 10.

Author: ben51degrees

tests/EnableCookiesTests.php

@@ -31,7 +31,7 @@
 use fiftyone\pipeline\core\SequenceElement;
 use fiftyone\pipeline\core\JsonBundlerElement;
 use PHPUnit\Framework\TestCase;
-use PHPUnit\Framework\Attributes\TestWith;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class CookieElement extends FlowElement
 {
@@ -58,13 +58,21 @@ public function processInternal($flowData): void
 
 class EnableCookiesTests extends TestCase
 {
+    public static function provider_testJavaScriptCookies()
+    {
+        return [
+            [false, false, false],
+            [true, false, false],
+            [false, true, true],
+            [true, true, true]
+        ];
+    }
+
     /**
      * Test that the cookie settings are respected correctly.
+     * @dataProvider provider_testJavaScriptCookies
      */
-    #[TestWith([false, false, false])]
-    #[TestWith([true, false, false])]
-    #[TestWith([false, true, true])]
-    #[TestWith([true, true, true])]
+    #[DataProvider("provider_testJavaScriptCookies")]
     public function testJavaScriptCookies($enableInConfig, $enableInEvidence, $expectCookie)
     {
         $jsElement = new JavascriptBuilderElement([
@@ -84,7 +92,7 @@ public function testJavaScriptCookies($enableInConfig, $enableInEvidence, $expec
 
         $js = $flowData->javascriptbuilder->javascript;
         $matches = substr_count($js, 'document.cookie');
-        if ($expectCookie) {
+        if ($expectCookie === true) {
             $this->assertSame(2, $matches);
         }
         else {

tests/SetHeaderTests.php

@@ -81,6 +81,8 @@ public static function provider_testGetResponseHeaderValue()
 
     /**
      * Test response header value to be set for UACH.
+     * 
+     * @dataProvider provider_testGetResponseHeaderValue
      */
     #[DataProvider("provider_testGetResponseHeaderValue")]
     public function testGetResponseHeaderValue($device, $expectedValue)
@@ -140,6 +142,7 @@ public static function provider_testGetResponseHeaderName_Valid()
 
     /**
      * Test get response header function for valid formats.
+     * @dataProvider provider_testGetResponseHeaderName_Valid
      */
     #[DataProvider("provider_testGetResponseHeaderName_Valid")]
     public function testGetResponseHeaderNameValid($data, $expectedValue)
@@ -161,6 +164,7 @@ public static function provider_testGetResponseHeaderName_InValid()
 
     /**
      * Test get response header function for valid formats.
+     * @dataProvider provider_testGetResponseHeaderName_InValid
      */
     #[DataProvider("provider_testGetResponseHeaderName_InValid")]
     public function testGetResponseHeaderNameInValid($data, $expectedValue)