Make ChatCompletionMessageToolCall
compatible with Mistral API
#368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the chat types, specifically the
ChatCompletionMessageToolCall
struct, to make it compatible with the Mistral API. Mistral does not specify thetype
when it calls a function, but OpenAI always does. Unfortunately, this change is breaking. I don't quite understand why this example outputs show thetype
function
but my tests with themistral-saba-latest
model don't.About the diff, I had some issues with carriage returns
\r
. I don't understand why my editors (Zed, nano, Sublime Text) are not supporting them correctly. So, let me know if you don't plan to accept the changes as is, and I'll spend some time fixing it. The only line that actually changes is line 396.Now that I have considered this PR a bit more, I wonder if it wouldn't be better to implement
Default
onChatCompletionToolType
and makeChatCompletionToolType::Function
the default value.