Skip to content

refactor: enhance deserialization error message #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2025
Merged

refactor: enhance deserialization error message #381

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
066e77a
refactor: enhance error message
cs50victor Jun 3, 2025
0cb8ac7
Merge branch 'main' into refactor/show_raw_deserialized
64bit Oct 20, 2025
0ae7ab2
Update async-openai/src/error.rs
64bit Oct 20, 2025
cb4e5a6
Update async-openai/src/error.rs
64bit Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions async-openai/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ pub enum OpenAIError {
#[error("{0}")]
ApiError(ApiError),
/// Error when a response cannot be deserialized into a Rust type
#[error("failed to deserialize api response: {0}")]
JSONDeserialize(serde_json::Error),
#[error("failed to deserialize api response: error:{0} content:{1}")]
JSONDeserialize(serde_json::Error, String),
/// Error on the client side when saving file to file system
#[error("failed to save file: {0}")]
FileSaveError(String),
Expand Down Expand Up @@ -81,9 +81,11 @@ pub struct WrappedError {
}

pub(crate) fn map_deserialization_error(e: serde_json::Error, bytes: &[u8]) -> OpenAIError {
let json_content = String::from_utf8_lossy(bytes);
tracing::error!(
"failed deserialization of: {}",
String::from_utf8_lossy(bytes)
json_content
);
OpenAIError::JSONDeserialize(e)

OpenAIError::JSONDeserialize(e, json_content)
}