Skip to content

Tweak conf section language #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Tweak conf section language #208

merged 2 commits into from
Oct 28, 2021

Conversation

stuarth
Copy link
Contributor

@stuarth stuarth commented Oct 27, 2021

Switching to js for the config sample causes the comment to render as a comment. Bit unfortunate, but probably a net improvement :)

Love the project!

Switching to `js` for the config sample causes the comment to render as a comment. Bit unfortunate, but probably a net improvement :)
@71
Copy link
Owner

71 commented Oct 27, 2021

Ah, good point, thanks! I also learned recently that GitHub supports jsonc, aka JSON with comments. Maybe that'd be a more accurate language.

@stuarth
Copy link
Contributor Author

stuarth commented Oct 27, 2021 via email

@stuarth
Copy link
Contributor Author

stuarth commented Oct 28, 2021

@71 updated -- we truly live in the best of all possible worlds now 😉

@71 71 merged commit d17c6cd into 71:master Oct 28, 2021
@71
Copy link
Owner

71 commented Oct 28, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants