Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable word highlighting for dance selection #283

Merged
merged 1 commit into from
Nov 10, 2022
Merged

enable word highlighting for dance selection #283

merged 1 commit into from
Nov 10, 2022
+1 −0

Conversation

kabouzeid
Copy link
Contributor

@kabouzeid kabouzeid commented Nov 10, 2022 •
edited
Loading

@kabouzeid
Copy link
Contributor Author

Before

Screen.Recording.2022-11-10.at.15.16.46.mov

After

Screen.Recording.2022-11-10.at.15.18.52.mov

@Delapouite
Copy link
Contributor

Thanks for taking the time to upload videos 👍

71
71 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Owner

@71 71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, awesome, thanks! Can you add a comment similar to the one in VSCodeVim to explain what this line does?

@kabouzeid
Copy link
Contributor Author

kabouzeid commented Nov 10, 2022 •
edited
Loading

Hmm, I'm not sure what the comment should say that is not already in the name of the command. Do you have a suggestion?

@71
Copy link
Owner

71 commented Nov 10, 2022

Fair enough, it'd be a little redundant.

@71 71 merged commit 0acf74f into 71:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@71 71

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kabouzeid @Delapouite @71