Skip to content

Added support for two new boards: LILYGO T-Display-S3-Pro-MVSRLora and LILYGO T-Display-S3-Pro-MVSRLora_NO_BATTERY. #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 29, 2025

Conversation

Llgok
Copy link
Contributor

@Llgok Llgok commented Apr 24, 2025

@78
Copy link
Owner

78 commented Apr 24, 2025

  1. Please segregate the bug fix code and the new boards code into two separate pull requests.
  2. The root README.md file does not have sufficient space to accommodate information about new boards. Consequently, please avoid making any modifications to this file.

@Llgok Llgok changed the title Fixed bugs in the LILYGO T-Circle-S3 board and added support for two new boards: LILYGO T-Display-S3-Pro-MVSRLora and LILYGO T-Display-S3-Pro-MVSRLora_NO_BATTERY. Added support for two new boards: LILYGO T-Display-S3-Pro-MVSRLora and LILYGO T-Display-S3-Pro-MVSRLora_NO_BATTERY. Apr 24, 2025
@Llgok
Copy link
Contributor Author

Llgok commented Apr 24, 2025

@78 Hello, I have changed the pull request to add support for two boards: LILYGO T-Display-S3-Pro-MVSRLora and LILYGO T-Display-S3-Pro-MVSRLora_NO_BATTERY, and also removed the modification to the README.md file in the root directory.

@78
Copy link
Owner

78 commented Apr 24, 2025

No PMIC or battery gauge?

@Llgok
Copy link
Contributor Author

Llgok commented Apr 25, 2025

@78 The code Sy6970 in the text refers to the PMIC.

@78
Copy link
Owner

78 commented Apr 28, 2025

I've double checked your product images. Found colors of emotional emojis might be incorrect.

@Llgok
Copy link
Contributor Author

Llgok commented Apr 29, 2025

@78 This was indeed an error; however, I have already fixed it. In panel_config, the member rgb_ele_order needs to be set to LCD_RGB_ELEMENT_ORDER_BGR.
1

@78 78 merged commit b5595c0 into 78:main Apr 29, 2025
1 check passed
zhuzizyf pushed a commit to zhuzizyf/xiaozhi-esp32 that referenced this pull request May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants