-
Notifications
You must be signed in to change notification settings - Fork 7
Updated firebase_remote_config_service.dart #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added try-catch to handle error in Remote Config initialisation. - Added 'force_update' key and assigned JSON value to it while set up initial default values, to match Firebase's variable configuration.
WalkthroughThe code consolidates remote configuration defaults from separate platform-specific keys into a single nested key and updates the initialization logic to include error handling with logging. The asynchronous setup steps in the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/app_core/lib/core/data/services/firebase_remote_config_service.dart (1)
28-39: Consider improving JSON formatting for better maintainability.The configuration consolidation is well-aligned with the documentation comments. However, the multi-line string formatting could be improved for better readability and reduced error-proneness.
Consider using a more structured approach:
- 'force_update': ''' - { - "android": { - "version": "1.0.0", - "allow_cancel": true - }, - "ios": { - "version": "1.0.0", - "allow_cancel": true - } - } - ''', + 'force_update': '{"android":{"version":"1.0.0","allow_cancel":true},"ios":{"version":"1.0.0","allow_cancel":true}}',Alternatively, you could use
jsonEncodewith a Map for type safety:import 'dart:convert'; // In _setDefaults method: 'force_update': jsonEncode({ 'android': {'version': '1.0.0', 'allow_cancel': true}, 'ios': {'version': '1.0.0', 'allow_cancel': true}, }),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/app_core/lib/core/data/services/firebase_remote_config_service.dart(2 hunks)
🔇 Additional comments (1)
apps/app_core/lib/core/data/services/firebase_remote_config_service.dart (1)
2-2: LGTM!The logger import is correctly added to support the error handling functionality in the initialize method.
Description
Type of Change
Summary by CodeRabbit