Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate project using rubocop-extension-generator #10

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

baelter
Copy link
Member

@baelter baelter commented Oct 23, 2024

WHY are these changes introduced?

Wanted to introduce a new cop. Found that specs didn't work. Everything was were outdated.

WHAT is this pull request doing?

Modernizing the entire project base off https://github.com/rubocop/rubocop-extension-generator
with spec, ci, linting, updated versions, linting etc.
And adds the cop I wanted to write EnsureRedirect

HOW can this pull request be tested?

Specs

@baelter baelter force-pushed the rubocop-extension-generator branch from 815692a to d2bc6be Compare October 23, 2024 13:04
Copy link
Contributor

@walro walro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit hard to review all that green/red, but all specs seems to be still be there and pass so that should be enough. Stellar work!

@baelter baelter force-pushed the rubocop-extension-generator branch from d2bc6be to f203208 Compare October 23, 2024 13:09
baelter and others added 3 commits October 23, 2024 15:14
Co-authored-by: Robin Wallin <[email protected]>
Co-authored-by: Robin Wallin <[email protected]>
@baelter baelter merged commit 8a5f5b7 into main Oct 23, 2024
1 check passed
@baelter baelter deleted the rubocop-extension-generator branch October 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants