This repository was archived by the owner on Aug 13, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since merging the new dependencies, there are a couple of critical issues (#37 & #39) that I don't get when running off of my fork. I think it would be prudent to only upgrade what's absolutely necessary to get this to run on react-native 0.50 and above rather than introducing multiple dependency changes, especially since the tests for this library aren't representative of whether it functions right now.
The fork I'm merging works in a production app and covers the bare minimum case. It also has issue #40 but that's nothing but a console warning, and tests/type-checking for this lib should be upgraded separately anyway.
(All those having the aforementioned critical issues are again encouraged to use my fork
https://github.com/foggy1/react-native-snackbar-dialog/archive/upgrade-flow-type-babel.tar.gz
as a dependency and placecd node_modules/react-native-snackbar-dialog && yarn build
in yourpostinstall
script.)