Skip to content

Remove Command + Add logic #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove Command + Add logic #173

wants to merge 2 commits into from

Conversation

wes-a2ai
Copy link
Contributor

@wes-a2ai wes-a2ai commented Mar 13, 2025

During the training session this morning, there was a scenario where someone added a package that was not a part of a repository in their config. There immediate reaction was "oh that's there now? I have to remove it??". The feedback was both:

  1. We'd rather not have to edit the config and just use rv remove
  2. If the add doesn't work, why should we have to remove it in the first place?

This PR both adds the rv remove functionality to mirror rv add and changes the logic of config editing to only write after a successful sync

@wes-a2ai wes-a2ai changed the title Remove Command Remove Command + Add logic Mar 13, 2025
@wes-a2ai wes-a2ai requested a review from Keats March 13, 2025 20:31
@dpastoor
Copy link
Member

This PR both adds the rv remove functionality to mirror rv add and changes the logic of config editing to only write after a successful sync

i think this needs a bit more design discussion around edge cases for whether we should only "commit" the package to the add after success. i'm not opposed to the concept but also there could be other situations where like if the add fails, but for other types of reasons and users think the package should be there so next time only need to sync.

we also have things like add --dry-run for the explicit purpose of "give it a try".

the thing I'm wondering is if someone adds they clearly wanted to use the package, so why go back to not using it vs working to get the rproject into an installable state kinda discussions

@wes-a2ai wes-a2ai closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants