-
Notifications
You must be signed in to change notification settings - Fork 3
Ensure lockfile is invalid if repo not present in config anymore #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@wes-a2ai could you add an e2e test for this for us to formally test before we merge this |
I think I'm struggling to understand what/how this PR is trying to address #112 and how to test. Even when I'm just running manually and changing my repository snapshot dates, I am still getting the packages are being sourced from the original repository. Original config:
Results (expected):
Remove library:
Changed config:
Results:
|
84cc812
to
9f83b3c
Compare
I forgot to invalidate the deps in the resolution as well, that should work now |
9f83b3c
to
ccd45ab
Compare
ccd45ab
to
ec3f98c
Compare
config
|
* Check whether to load databases after sync mode check Closes #205 * replace `from_lockfile` in resolution if upgrading. Still need to test * database loading + adjusting resolved deps * Remove extra test element from .gitignore * upgrade project example updated from #196 * addressing PR comments by simplifying matching fxn and creating new resolved vector * format + address PR comments --------- Co-authored-by: wes-a2ai <[email protected]>
Closes #112