Fix issue #1 added attribute for DefaultRolloverStrategy#2
Closed
Jamir-boop wants to merge 1 commit intoA360-Tools:mainfrom
Closed
Fix issue #1 added attribute for DefaultRolloverStrategy#2Jamir-boop wants to merge 1 commit intoA360-Tools:mainfrom
Jamir-boop wants to merge 1 commit intoA360-Tools:mainfrom
Conversation
… StartLoggerSession.java and added 1000 default on label
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Bot-Dev-RPA
reviewed
Apr 8, 2026
Member
Bot-Dev-RPA
left a comment
Bot-Dev-RPA
left a comment
There was a problem hiding this comment.
Thanks for the fix! The Java changes look good:
fileIndex: "nomax"on theDefaultRolloverStrategycorrectly removes the 8-file cap that caused log overwriting.- The label update on
StartLoggerSession.javaadds clarity about the default value.
One thing to fix: the settings.gradle change (adding org.gradle.toolchains.foojay-resolver-convention) is unrelated to this fix. Please add a new commit reverting that file to its original state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added attribute for DefaultRolloverStrategy on StartLoggerSession.java and added 1000 default on label
Fixes #1