Skip to content

fix: handle shadow host and slot ancestors in isElementClickable() #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ezzamo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle shadow host and slot ancestors in isElementClickable() #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions ShyMouse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,11 @@ class ShyMouse {

// Check pointer-events on ancestors
let ancestor = el.parentElement;
while (ancestor && ancestor !== document.body) {
while (ancestor && ancestor !== document.body && ancestor !== document.documentElement) {
const ancestorStyle = window.getComputedStyle(ancestor);
if (ancestorStyle.pointerEvents === 'none') return false;
ancestor = ancestor.parentElement;
const root = typeof ancestor.getRootNode === 'function' ? ancestor.getRootNode() : null;
ancestor = ancestor.parentElement || ancestor.assignedSlot || root?.host || null;
}

// Multi-point sampling (center + 4 cardinal points + 4 corners)
Expand Down Expand Up @@ -353,12 +354,24 @@ class ShyMouse {
} else {
// Check if element is ancestor of topElement
let current = topElement;
while (current && current !== document.body) {
while (current && current !== document.body && current !== document.documentElement) {
if (current === el) {
clickablePoints++;
break;
}
current = current.parentElement;
const root = typeof current.getRootNode === 'function' ? current.getRootNode() : null;
current = current.parentElement || current.assignedSlot || root?.host || null;
}

// Also accept wrapper/host elements that are ancestors of the target.
current = el;
while (current && current !== document.body && current !== document.documentElement) {
if (current === topElement) {
clickablePoints++;
break;
}
const root = typeof current.getRootNode === 'function' ? current.getRootNode() : null;
current = current.parentElement || current.assignedSlot || root?.host || null;
}
}
}
Expand Down Expand Up @@ -2000,4 +2013,4 @@ class ShyMouse {
}
}

module.exports = ShyMouse;
module.exports = ShyMouse;