Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iceberg flux inputs and configuration files #13

Merged

Conversation

blimlim
Copy link

@blimlim blimlim commented Dec 18, 2024

This pull request updates the dev-preindustrial+concentrations configuration to use the new iceberg melt scheme.

It sets the executable to PR27-5, which includes code for wombatlite + cable 3 + iceberg flux.

The ice, ocean, and coupler namelist files include the necessary changes for using the iceberg scheme, and land ice melt water and heat fluxes have been added to the ocean diagnostics.

@blimlim blimlim requested a review from matt-csiro December 18, 2024 04:14
Copy link
Collaborator

@matt-csiro matt-csiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this request are consistent with what are required to enable the pseudo-iceberg freshwater flux scheme from Dave Bi (and used in CM2) into ESM1.x.
Matt.

@CodeGat
Copy link
Member

CodeGat commented Dec 18, 2024

@blimlim There are a few failing QA tests at the moment - would you be able to fix them up before I approve? Happy to help if you need.

@blimlim blimlim force-pushed the iceberg-flux-inputs+config-files branch from 3a7933d to a4509f5 Compare December 19, 2024 01:52
Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the QA tests now pass. Approved!

@blimlim
Copy link
Author

blimlim commented Dec 19, 2024

Awesome, thanks @CodeGat and @matt-csiro for your help with this!

@blimlim blimlim merged commit 4959021 into dev-preindustrial+concentrations Dec 19, 2024
10 checks passed
@blimlim blimlim deleted the iceberg-flux-inputs+config-files branch December 19, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants