Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast when installing manifest #259

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Fail fast when installing manifest #259

merged 1 commit into from
Mar 25, 2025

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Mar 25, 2025

Background

When installing models, the cause of installation failure causes can be obscured by spack continuing to install other dependencies. With --fail-fast, spack will exit more quickly and the cause of failures will no longer require a lot of scrolling.

The PR

  • Add --fail-fast to the spack install flags

@CodeGat CodeGat added type:enhancement Improvements to existing features priority:low version:MINOR Doesn't require update to Model Deployment Repositories for:v4 Applies to `v4` labels Mar 25, 2025
@CodeGat CodeGat self-assigned this Mar 25, 2025
@CodeGat CodeGat requested a review from harshula March 25, 2025 04:19
harshula
harshula approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@CodeGat CodeGat merged commit ca075de into v4 Mar 25, 2025
@CodeGat CodeGat deleted the fail-fast-on-install branch March 25, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshula harshula harshula approved these changes

Assignees

@CodeGat CodeGat

Labels
for:v4 Applies to `v4` priority:low type:enhancement Improvements to existing features version:MINOR Doesn't require update to Model Deployment Repositories
Projects
Model Release
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeGat @harshula