Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes numerous issues when using oneAPI #34

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

manodeep
Copy link

  • switched to the oneAPI 2025 module on gadi (within build.sh)
  • updated to recent modules for openmpi/5.0.5 and netcdf/4.9.2 (within build.sh)
  • set to use the llvm-ar by default (in preparation for using -flto down the track, when llvm-ar will be necessary but no drawbacks from what I can tell for now)
  • removed the unsupported flag -ip
  • added the recommended flag -qno-opt-dynamic-align for removing one possible avenue for non-deterministic results
  • had to hardcode cq as the archiver flags for mct/Makefile and mpeu/Makefile - unclear to me why scrip/Makefile uses $ARFLAGS but these two don't. Hardcoding the flags preserves previous behaviour. See Inconsistencies with using ARFLAGS when creating static libraries #31
  • Fixed Compiler warning about function without a proto-type (get_zeits.c) #33 (which turned out to be because of the old-style function definition - the prototypes were present)
  • commented out the section with configure and configure.ac where it checks for mismatched arguments. Not sure why configure thought that the flags were supported and kept adding them in the compile flags, but the compiler (ifx) does not support them.

Fixes #26, #30, #33

@manodeep manodeep self-assigned this Mar 21, 2025
@manodeep
Copy link
Author

I have confirmed that the library builds on gadi using build.sh

@manodeep manodeep marked this pull request as draft March 21, 2025 04:15
@manodeep
Copy link
Author

@CodeGat The CI is failing and I need to see the build/lib/mctdir/config.log to figure out why. Is it possible to retrieve that or at least cat the contents of that log file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warning about function without a proto-type (get_zeits.c) configure error when using oneAPI
1 participant