wip: recklessness updates #3074
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with recklessness ratings from both attacker and defender being combined as multipliers, instead of additives. With 2 players that have recklessness speced, this provided a 44% damage increase, instead of 40%
Starts to fix some issues with Recklessness! combat message prefixes, although still needs to be investigated more:
Scenario A: a non-reckless player attacks a player currently in reckless mode. Both players currently receive the Recklessness! prefix for the combat message, as the attack received a bonus from the defender being in reckless mode. This is confusing for the attacker, since they might not even have recklessness trained.
Scenario B: a reckless player attacks a monster. When the monster hits the player, the combat message is currently prefixed with Recklessness!, since the monster received a damage bonus from the player being in reckless mode. Should this message only have been sent if the attacker was in reckless mode?