Disable AWS X-Ray in resource-api until it's needed.#18
Open
epf wants to merge 1 commit intoACloudGuru-Resources:masterfrom
Open
Disable AWS X-Ray in resource-api until it's needed.#18epf wants to merge 1 commit intoACloudGuru-Resources:masterfrom
epf wants to merge 1 commit intoACloudGuru-Resources:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resource-api microservice would immediately error out and stop working for me when it was unable to contact the x-ray daemon. I don't remember if this was a problem when I was using the image from your Docker Hub, but it definitely wasn't working when I started building my own images on CodeBuild.
This patch adds a configurable
AWS_XRAY_SDK_ENABLEDvariable to the helm template and keeps it disabled until we're ready for it with the v3 deployment in the AppMesh chapter.