Fix(setup.sh): Correct path to extra_deps_from_github.txt #2584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
This PR fixes a bug in
setup.shthat causes the script to fail with a "File not found" error when trying to installextra_deps_from_github.txt.Why is this change necessary?
The path used in the uv pip install command (${MAXTEXT_REPO_ROOT}/extra_deps_from_github.txt) is incorrect. After the major repository refactor that moved project code into the src/ directory, the correct location for this file is now
${MAXTEXT_REPO_ROOT}/src/install_maxtext_extra_deps/extra_deps_from_github.txt.How does this PR fix the issue?
This PR updates the uv pip install command in setup.sh to point to the correct file path.
Before:
After:
FIXES: b/454233010
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.