Skip to content

Conversation

@bvandermoon
Copy link
Collaborator

@bvandermoon bvandermoon commented Nov 4, 2025

Description

setup.sh was updated in #2541 as part of the ongoing restructuring effort. @NuojCheng saw an error when running bash setup.sh after this change:

Installing "tpu-requirements.txt" with pinned commits.
error: File not found: `dependencies/requirements/extra_deps_from_github.txt

This PR points the setup script to the correct file location

Tests

  • Reproduced the error on main with bash tools/setup/setup.sh and bash tools/setup/setup.sh MODE=nightly
  • Re-ran both commands on this branch and the script finished successfully

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

Copy link
Collaborator

@NuojCheng NuojCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Branden for the quick fix!

@SamuelMarks
Copy link
Collaborator

Thanks, good find, was from a last minute reversion of file locations

@SamuelMarks SamuelMarks self-requested a review November 4, 2025 02:01
@copybara-service copybara-service bot merged commit 4095016 into main Nov 4, 2025
41 checks passed
@copybara-service copybara-service bot deleted the bvandermoon-setup-file-path branch November 4, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants