Skip to content

extra_deps_from_github.txt is now only searched for in filesystem path only… so COPY over there #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

extra_deps_from_github.txt is now only searched for in filesystem path only… so COPY over there #2589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dependencies/dockerfiles/maxtext_db_dependencies.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ ENV MAXTEXT_REPO_ROOT=/deps
WORKDIR /deps

# Copy setup files and dependency files separately for better caching
COPY tools/setup /deps/tools/setup/
COPY dependencies/requirements/ /deps/dependencies/requirements/
COPY src/install_maxtext_extra_deps/extra_deps_from_github.txt /deps/dependencies/requirements/
COPY tools/setup tools/setup/
COPY dependencies/requirements/ dependencies/requirements/
COPY src/install_maxtext_extra_deps/extra_deps_from_github.txt src/install_maxtext_extra_deps/

# Install dependencies - these steps are cached unless the copied files change
RUN echo "Running command: bash setup.sh MODE=$ENV_MODE JAX_VERSION=$ENV_JAX_VERSION LIBTPU_GCS_PATH=${ENV_LIBTPU_GCS_PATH} DEVICE=${ENV_DEVICE}"
Expand Down
6 changes: 3 additions & 3 deletions dependencies/dockerfiles/maxtext_dependencies.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ ENV MAXTEXT_REPO_ROOT=/deps
WORKDIR /deps

# Copy setup files and dependency files separately for better caching
COPY tools/setup /deps/tools/setup/
COPY dependencies/requirements/ /deps/dependencies/requirements/
COPY src/install_maxtext_extra_deps/extra_deps_from_github.txt /deps/dependencies/requirements/
COPY tools/setup tools/setup/
COPY dependencies/requirements/ dependencies/requirements/
COPY src/install_maxtext_extra_deps/extra_deps_from_github.txt src/install_maxtext_extra_deps/

# Install dependencies - these steps are cached unless the copied files change
RUN echo "Running command: bash setup.sh MODE=$ENV_MODE JAX_VERSION=$ENV_JAX_VERSION LIBTPU_GCS_PATH=${ENV_LIBTPU_GCS_PATH} DEVICE=${ENV_DEVICE}"
Expand Down
6 changes: 3 additions & 3 deletions dependencies/dockerfiles/maxtext_gpu_dependencies.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ ENV MAXTEXT_REPO_ROOT=/deps
WORKDIR /deps

# Copy setup files and dependency files separately for better caching
COPY tools/setup /deps/tools/setup/
COPY dependencies/requirements/ /deps/dependencies/requirements/
COPY src/install_maxtext_extra_deps/extra_deps_from_github.txt /deps/dependencies/requirements/
COPY tools/setup tools/setup/
COPY dependencies/requirements/ dependencies/requirements/
COPY src/install_maxtext_extra_deps/extra_deps_from_github.txt src/install_maxtext_extra_deps/

# Install dependencies - these steps are cached unless the copied files change
RUN echo "Running command: bash setup.sh MODE=$ENV_MODE JAX_VERSION=$ENV_JAX_VERSION DEVICE=${ENV_DEVICE}"
Expand Down
6 changes: 3 additions & 3 deletions dependencies/dockerfiles/maxtext_jax_ai_image.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ARG JAX_AI_IMAGE_BASEIMAGE

# JAX AI Base Image
FROM $JAX_AI_IMAGE_BASEIMAGE

Check warning on line 4 in dependencies/dockerfiles/maxtext_jax_ai_image.Dockerfile

View workflow job for this annotation

GitHub Actions / tpu_image / Build and upload image (v4-8)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG $JAX_AI_IMAGE_BASEIMAGE results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 4 in dependencies/dockerfiles/maxtext_jax_ai_image.Dockerfile

View workflow job for this annotation

GitHub Actions / gpu_image / Build and upload image (a100-40gb-4)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG $JAX_AI_IMAGE_BASEIMAGE results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/
ARG JAX_AI_IMAGE_BASEIMAGE

ARG COMMIT_HASH
Expand All @@ -16,9 +16,9 @@
WORKDIR /deps

# Copy setup files and dependency files separately for better caching
COPY tools/setup /deps/tools/setup/
COPY dependencies/requirements/ /deps/dependencies/requirements/
COPY src/install_maxtext_extra_deps/extra_deps_from_github.txt /deps/dependencies/requirements/
COPY tools/setup tools/setup/
COPY dependencies/requirements/ dependencies/requirements/
COPY src/install_maxtext_extra_deps/extra_deps_from_github.txt src/install_maxtext_extra_deps/

# For JAX AI tpu training images 0.4.37 AND 0.4.35
# Orbax checkpoint installs the latest version of JAX,
Expand Down
Loading