-
Notifications
You must be signed in to change notification settings - Fork 2
Create README.md for running a JAX workload integrated with elasticity primitives #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please break each sentence into its own line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the bash sections more aligned with go/shell-style#shell-style-guide?
good_slice_count = kv[2] | ||
} | ||
} | ||
if (prev_good_slice_count != "" && prev_good_slice_count != good_slice_count) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems easily broken. Is there an alternate way to extract this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Parsing logs is going to be brittle. Another option would be to export metrics around this to tensorboard which hopefully are better structured and can be extracted for a similar assertion.
eac9e9e
to
a4f17a3
Compare
a4f17a3
to
b8c1471
Compare
This has been verified with 3 v5e-32 slices. I am waiting on AI-Hypercomputer/maxtext#1310 to be merged before we can recommend customers to use the maxtext HEAD to run this e2e workload