Typing args (initial)
#418
Open
+582
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcie
requested review from
Obliviour,
44past4,
sharabiani,
pawloch00,
BluValor and
RoshaniN
as code owners
pawloch00
reviewed
Apr 29, 2025
| ] | ||
|
|
||
|
|
||
| class StorageAttachArgs(ClusterConfig): |
There was a problem hiding this comment.
StorageAttachArgs and StorageCreateArgs share many fields. Can we move them to new, shared class?
pawloch00
reviewed
Apr 29, 2025
| from typing import Any | ||
|
|
||
|
|
||
| def apply_args(main_args: Namespace, annotation: Any) -> Any: |
There was a problem hiding this comment.
Bad naming imo. What does apply_args mean?
pawloch00
reviewed
Apr 29, 2025
|
|
||
|
|
||
| def apply_args(main_args: Namespace, annotation: Any) -> Any: | ||
| args = annotation() |
There was a problem hiding this comment.
There is no information that annotation is callable. Please add docstring for this function
pawloch00
reviewed
Apr 29, 2025
| mount_options: Optional[str] = 'implicit-dirs' | ||
|
|
||
|
|
||
| class StorageCreateArgs(ClusterConfig): |
There was a problem hiding this comment.
Maybe it should be dataclass? If I want to test StorageCreate command in unit tests(in the future) and I want to pass StorageCreateArgs, is there any way to pass them via constructor?
There was a problem hiding this comment.
pawloch00
reviewed
Apr 29, 2025
| ] # The project name lives on the last line of the output | ||
|
|
||
|
|
||
| def get_zone(): |
There was a problem hiding this comment.
This are general functions, not specific to args. Maybe they should be moved to utils?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
argsparameter