-
Notifications
You must be signed in to change notification settings - Fork 45
feat: Added an update to CoreDNS #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Added an update to CoreDNS #501
Conversation
… create-pathways is used, it will default to CoreDNS.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Danny!
…cessary' function.
…tions, along with some helper functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Danny!
I also think one more thing we should do is add a unit test for this addition. Though it seems like there are very few set up standards for this. Maybe @pawloch00 or others can chime in on where best to create the unit tests.
https://github.com/AI-Hypercomputer/xpk/tree/develop/src/xpk/core/tests/unit
Did testing scenarions included only TPU clusters? What with clusters created with GPUs, especially A3 Mega or ultra, that are created using cluster toolkit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my perspective, but I'm not an XPK owner, so best to get verification from @Obliviour or @pawloch00
@pawloch00 please review this PR again |
Please ignore integration tests failing for now. I will try to fix it and let you know |
Okay, Thanks! |
Please accept collaborator invitation and rerun the tests |
Fixes / Features
Enhance DNS Scalability for Large-Scale Testing:
Testing / Documentation
When using the command
python3 xpk.py cluster create-pathways
to create a cluster, CoreDNS will be used by default. For the general commandpython3 xpk.py cluster create
, kube-dns is still the default.